|
|
| (2 intermediate revisions by the same user not shown) |
| Line 3: |
Line 3: |
| | |} | | |} |
| | | | |
| − | ==Functional Requirements==
| + | In general, there are a number of key considerations that are driving the code decisions and architecture of PCGen. |
| | | | |
| − | The following functional requirements are provided for use in understanding the basis for the PCGen architecture. Functional requirements are constraints on features as they appear to a user of PCGen.
| + | =Subsystem Isolation= |
| | + | Overall, we want the subsystems (loader/core/output) to be sufficiently independent of each other that they don't interact except through a well-defined API and also so they only operate at the appropriate times... Meaning the once load is complete, the loader system should not need to be called again. Also, output should be called during output and not during regular character processing. |
| | + | Unfortunately, both of these are not true with the existing systems... it is possible to write a token that both uses items from the output tokens as well as is parsed at runtime - meaning all of the systems are intertwined today. The strategic designs that will prevent that interaction are described below. |
| | | | |
| − | ===Compatibility with Previous Versions=== | + | =Catch Errors Early= |
| | + | Errors in the data files should be caught during data file load, and should not trigger runtime errors. |
| | | | |
| − | A version of PCGen must be fully capable of loading LST data files that were compatible with the previous release. Any tokens that were deprecated in the previous revision may be removed. For example: PCGen 5.16 must be capable of fully loading PCGen 5.14 LST data files. Data from older 5.x releases (in particular PCGen 5.12 and 5.10) may be compatible with PCGen 5.16; however, there are known ambiguities that prevent 100% compatibility with older releases.
| + | =Eliminate Hardcoding= |
| | + | Eliminating hard coded values and special cases that currently exist in the PCGen code base will allow PCGen to more easily support our existing systems and non-d20 systems. The side effect here is an increasingly data-driven design. |
| | | | |
| − | With few exceptions, this requirement must be met. Other features of the system (requirements and other good design guidelines) will be sacrificed to meet this requirement. Exceptions to this requirement require unique conversion scripts (which may prompt the user to resolve ambiguity) to be available in the LST Converter.
| + | =Order of operations clarity= |
| | + | There are two order of operations items we are trying to address |
| | | | |
| − | All tokens deprecated in a given release of PCGen should have automatic conversion using the LST Converter if there is equivalent function in the new version. To remove function from PCGen requires explicit approval from the [[Content]] team
| + | ==In Data== |
| | + | Right now, for a token like REACH, there is an order of operations ambiguity - what Template is applied is not exactly clear. This is one example of many in the system. The new formula system handles this one with PRIORITY=x. |
| | | | |
| − | <b>Basis:</b> There is a tremendous investment in the PCGen code, data and documentation. This compatibility requirement ensures the ability to leverage that time investment, especially in data and documentation.
| + | ==In Code== |
| − | | + | Effectively there are certain things that must happen "first" - except in many cases, there are loops or other conditions that mean we need designs and technologies that overcome those "reference before constructed" situations. |
| − | ===Increased Flexibility===
| |
| − | | |
| − | Eliminating hard coded values and special cases that currently exist in the PCGen code base will allow PCGen to more easily support non-d20 systems. In addition, increased flexibility will provide for faster feature enhancement, providing additional benefit to users.
| |
| − | | |
| − | <b>Basis:</b> Desire for faster turnover of feature requests, and long-term strategy to expand the PCGen universe to include non-d20 based game systems to increase function for existing users and to attract new users to PCGen.
| |
| − | | |
| − | ==Structural Requirements==
| |
| − | | |
| − | The following structural requirements are provided for use in understanding the basis for the PCGen architecture. Structural requirements are constraints on features as they appear to a developer of PCGen.
| |
| − | | |
| − | Note: It is recognized that some of these items would qualify more as "design" than "architecture", as they are general features or characteristics of well-written software systems. Without any disrespect for software architecture purists, we include a number of those design characteristics, as they help to contrast the current PCGen architecture from architecture of earlier versions of PCGen.
| |
| − | | |
| − | ===Minimize Process/Structural Models===
| |
| − | | |
| − | PCGen should have a minimal set of design structures used to specify the functions required to build a Player Character.
| |
| − | | |
| − | <b>Basis:</b> This minimizes the number of mental models a developer must understand. Reduced quantity of design patterns and structures improves the ability of new (and existing!) developers to understand the code. This also allows greater code reuse and reduces code duplication (which is subject to copy/paste error). Selection of appropriate models will also reduce the number of exceptions in the code, eliminating further risk of bugs and confusion for developers.
| |
| − | | |
| − | ===Information Hiding===
| |
| − | | |
| − | The format of data files on disk should be independent of the processing of a game system or Player Character.
| |
| − | | |
| − | <b>Basis:</b> This insulates the code (modifying a player character or the game system data) from changes in the data file format. This increases the flexibility to add features to PCGen without core changes. This facilitates unit testing by improving component isolation.
| |
| − | | |
| − | ===Data Encapsulation===
| |
| − | | |
| − | There should be defined and limited interfaces between modules of PCGen.
| |
| − | | |
| − | <b>Basis:</b> This improves code maintainability. This truly insulates modules of PCGen from changes elsewhere in the system. This therefore facilitates parallel development. This also improves the ability to unit test the code, as "mock" objects that implement the framework can be used for testing.
| |
| − | | |
| − | ===Catch Errors Early===
| |
| − | | |
| − | Errors in the data files should be caught during data persistence file load, and should not trigger runtime errors.
| |
| − |
| |
| − | <b>Basis:</b> Given the Rules Persistence System being independent of the internal data structure, all items will be resolved at Data Load. This will ensure that all objects in a given namespace possess a unique KEY, regardless of the source file. In addition, all object references can be validated to ensure an object that was actually constructed and loaded.
| |
| − | | |
| − | ===Stable Code Structure===
| |
| − | | |
| − | Dependency between packages and classes will result in a Directed Acyclic Graph.
| |
| − | | |
| − | <b>Basis:</b> The PCGen code base is over 2,000 classes. This is a significant code base and requires isoloating subsystems and defining dependencies in order to minimize the impact of code changes. Improved code structure also facilitates testing. Eliminating tangles in Class dependency will improve the ability to write true unit tests (tests that work on a single Class). This means it will be possible to catch smaller errors due to incorrect modifications of the PCGen code base. Improved structure also facilitates understanding of the code by developers. The overall impact of good code structure is seen to both developers and end users as improved speed and ability to modify the PCGen code.
| |
| − | | |
| − | For further information on why this is important, you can read more about [http://www.objectmentor.com/resources/articles/granularity.pdf granularity] at ObjectMentor
| |
| − | | |
| − | ===Avoid Contracts===
| |
| − | | |
| − | Two forms of contracts should be avoided: (1) When a developer makes a code modification, the developer should not be forced to make a matching modification in another location in the code. (2) When a change is made to the internal data structure, a significant amount of "reorganization" to ensure a valid data structure should not be necessary.
| |
| − | | |
| − | <b>Basis:</b> Contracts cause problems because they introduce bugs into software when matching changes are not made. They also make it more difficult for developers to understand the architecture of a system, because they are forced to focus on adhering to the contracts. Data structure contracts can result in invalid data structures, and often lead to performance issues as the data structure is validated and corrected.
| |
| − | | |
| − | ===Minimize Order Dependency===
| |
| − | | |
| − | The number of order dependent operations should be minimized.
| |
| − | | |
| − | <b>Basis:</b> Order dependency can cause significant issues, especially as it is hard to maintain accurate documentation of such restrictions. Operations that are not order dependent can also be parallelized (e.g. on multi-processor systems) to improve performance.
| |
In general, there are a number of key considerations that are driving the code decisions and architecture of PCGen.
Subsystem Isolation
Overall, we want the subsystems (loader/core/output) to be sufficiently independent of each other that they don't interact except through a well-defined API and also so they only operate at the appropriate times... Meaning the once load is complete, the loader system should not need to be called again. Also, output should be called during output and not during regular character processing.
Unfortunately, both of these are not true with the existing systems... it is possible to write a token that both uses items from the output tokens as well as is parsed at runtime - meaning all of the systems are intertwined today. The strategic designs that will prevent that interaction are described below.
Catch Errors Early
Errors in the data files should be caught during data file load, and should not trigger runtime errors.
Eliminate Hardcoding
Eliminating hard coded values and special cases that currently exist in the PCGen code base will allow PCGen to more easily support our existing systems and non-d20 systems. The side effect here is an increasingly data-driven design.
Order of operations clarity
There are two order of operations items we are trying to address
In Data
Right now, for a token like REACH, there is an order of operations ambiguity - what Template is applied is not exactly clear. This is one example of many in the system. The new formula system handles this one with PRIORITY=x.
In Code
Effectively there are certain things that must happen "first" - except in many cases, there are loops or other conditions that mean we need designs and technologies that overcome those "reference before constructed" situations.
