Critical Thinking - Altering how we do things

From PCGen Wiki
Revision as of 06:25, 9 August 2014 by LegacyKing (talk | contribs) (First wave)
(diff) ← Older revision | Latest revision (diff) | Newer revision → (diff)
Jump to: navigation, search

This is a scratch pad for critical thinking to review how we do things, why we do things, and do we still need to do things that way.


PROHIBITSPELL

Issue - we use 'ALIGNMENT' which has no corresponding tag in spells. This is actually a "Magic" tag that takes a DESCRIPTOR and assigned an internal PRERULE to it from the hard-coded preference house rule.

Solution:

  1. Change the 'ALIGNMENT' to 'DESCRIPTOR'
  2. Add PRERULE:1,x to the tag
  3. Change the Preference House Rule to an actual Soft-Coded rule
  4. Deprecate/Remove the Hard-coded rule

Example of new LST syntax:

   PROHIBITSPELL:DESCRIPTOR.Good|PREMULT:1,[PREALIGN:LE,NE,CE],[PREDEITYALIGN:LE,NE,CE]|PRERULE:1,Spell_Alignment_Restriction


UI Clutter

ISSUE: Hard-coded d20 reliance - Our displays should be a bit more dynamic to not display empty fields.

Example: Spells Tab - If a Spell has no SAVEINFO, then the UI should not display a blank Save Info.

Similar Names

FAVCLASS vs. FAVOREDCLASS

This should be a no-no. This has the exact same function and one should be replaced by the other. We should avoid FILE specific tags with similar functions. This only serves to create frustration and confusion to new users and experienced monkeys alike.